moap should detect an email address from the environment that is already enclosed by < and >

[zaheermerali@…]

moap should detect an email address from the environment that is already enclosed by < and >

[anonymous]

Could you give an example ? I don't understand the ticket.

[zaheermerali@…]

Sorry lacks context. If my EMAIL_ADDRESS environment variable already contains my email address enclosed inside < >, moap should not add an extra < and > when preparing ChangeLog?.

[thomas]

I've never seen anyone use EMAIL_ADDRESS with angle brackets in it. Why do you have that ?

[zaheermerali@…]

Was a mistake, but probably very easy to handle case for moap cl prepare. I believe cl.pl handled it ok.

[thomas]

from my copy of cl.pl:

my $email_address = $ENV{CHANGE_LOG_EMAIL_ADDRESS}
  || $ENV{EMAIL_ADDRESS}
  || "set EMAIL_ADDRESS environment variable";
open CHANGE_LOG, "> ChangeLog" or die "Could not write ChangeLog\n.";
print CHANGE_LOG "$date  $name  <$email_address>\n\n";

It doesn't look like it does what you say.

I should add CHANGE_LOG_EMAIL_ADDRESS support though :)

[zaheermerali@…]

aaah that explains it my CHANGE_LOG_EMAIL_ADDRESS had it without the angle brackets but my EMAIL_ADDRESS had it with!

[thomas]

see [220] for the CHANGE_LOG_EMAIL_ADDRESS change