Modify ↓

Ticket #280 (closed defect: fixed)

Opened 5 years ago

Last modified 4 years ago

problem with quotes in changelog comment entries (in bzr backend)

Reported by: arkadini@… Owned by: thomas
Priority: major Milestone: 0.2.7
Component: moap Version: TRUNK
Keywords: Cc:

Description

... moap seems to think that things with slashes are dirs/files? :/

Attachments

bzr_git_commit.diff Download (1.2 KB) - added by arkadini@… 5 years ago.

Change History

comment:1 Changed 5 years ago by thomas

  • Reporter changed from anonymous to arkadini@…

comment:2 Changed 5 years ago by arkadini@…

  • Summary changed from slash ("/") character can't be used in changelog comment entries to problem with quotes in changelog comment entries (in bzr backend)

Misdiagnosed.

The problem turned out to be specifically in the bzr backend commit() method (and a similar problem exists in git backend too). Literal passing of arbitrary strings to shell commands almost always requires some escaping - which in this case was missing.

Attaching a patch that makes bzr and git backends use a temporary file for passing commit messages instead of as a command line argument.

Changed 5 years ago by arkadini@…

comment:3 Changed 5 years ago by arkadini@…

Note: the git bit of the patch is untested, but the bzr part works. If git behaves according to it's man page then it should work too.

comment:4 Changed 4 years ago by thomas

  • Status changed from new to closed
  • Resolution set to fixed

(In [383]) patch by: Arek Korbik

  • moap/test/test_vcs_bzr.py:
  • moap/test/test_vcs_git.py:
  • moap/vcs/bzr.py:
  • moap/vcs/git.py: Fix for quotes in commit messages. Fixes #280.

comment:5 Changed 4 years ago by thomas

  • Milestone set to 0.2.7
View ↑

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.