[svn] propedit on externals is not recognized as a change

[thijsvermeir@…]

When I change the externals of a folder this is not recognized by moap as a change on the project.

[thomas]

Not sure how to handle it in the code. Right now the VCS instance is asked for a diff, and based on the lines in the diff it decides which files got changed. Similar problem is deletion of files.

Open to suggestions on how to abstract this nicely. How do other VCS's implement things like externals ?

[thomas]

(In [344]) * moap/vcs/vcs.py:

Add getPropertyChanges() to get paths that have changed properties.

• moap/test/test_vcs_svn.py:
• moap/vcs/svn.py: Implement it for svn.
• moap/command/cl.py: Use it in moap cl prep so that we allow commenting on property changes. Fixes #286.

[anonymous]

Not sure how to handle it in the code. Right now the VCS instance is asked for a diff, and based on the lines in the diff it decides which files got changed. Similar problem is deletion of files.

Open to suggestions on how to abstract this nicely. How do other VCS's implement things like externals ? Changed 15 months ago by thomas ¶

• status changed from new to closed
• resolution set to fixed

(In [344]) * moap/vcs/vcs.py:

Add getPropertyChanges() to get paths that have changed properties.

• moap/test/test_vcs_svn.py:
• moap/vcs/svn.py: Implement it for svn.
• moap/command/cl.py: Use it in moap cl prep so that we allow commenting on property changes. Fixes #286.

I'm closing it according to the last comment.
----------
 nike air yeezy