Ticket #296 (new defect)
Use bzrlib for bzr vcs backend
| Reported by: | Jelmer Vernooij <jelmer@…> | Owned by: | jelmer@… |
|---|---|---|---|
| Priority: | major | Milestone: | 0.2.7 |
| Component: | moap | Version: | TRUNK |
| Keywords: | Cc: | moap@… |
Description
The attached patch makes moap change the bzr backend to use bzr's API directly rather than invoking the command-line tool.
This fixes some of the tests for me and it should make use of bzr from moap somewhat faster.
Attachments
-
moap-bzrlib.diff
(5.3 KB) -
added by Jelmer Vernooij <jelmer@…> 5 years ago.
-
moap-bzrlib.2.diff
(3.3 KB) -
added by jelmer@… 4 years ago.
- updated patch against current trunk
-
bzrlib-fix.patch
(769 bytes) -
added by moap@… 3 years ago.
- fix for changelog prepare + bzrlib
Change History
Changed 4 years ago by jelmer@…
-
attachment
moap-bzrlib.2.diff
added
updated patch against current trunk
comment:1 Changed 4 years ago by thomas
- Owner changed from thomas to jelmer@…
Hi Jelmer,
why is it better to use bzr's API directly ? Is it guaranteed to be more stable ?
comment:2 Changed 4 years ago by jelmer@…
Hi Thomas,
The main advantages are speed (importing bzrlib only once rather than every time the "bzr" command-line is executed) and coping with with some corner cases better (I think currently committing a file with a space in the name will fail).
The bzr API is guaranteed to be stabler than the command-line UI, although changes are generally rare. If the API is changed the old behaviour will be supported for a couple of releases and deprecation warnings added.
comment:4 Changed 4 years ago by thomas
Hi Jelmer,
sorry for being lazy, I've been working more on other projects recently.
How about I give you commit access and you can maintain the bzr backend ? What do you think ?
comment:5 Changed 4 years ago by Jelmer Vernooij <jelmer@…>
Hi Thomas,
Thanks, I'd like to maintain the bzr backend as a committer. What information do you need for me to create an account, etc?
comment:6 Changed 3 years ago by thomas
Hi Jelmer,
just your public ssh key should be enough, then I'll set it up on the server. Will need to figure out how to set it up, but should not be a big deal.
comment:7 Changed 3 years ago by moap@…
- Cc moap@… added
I noticed that this ticket hasn't been closed, so I figured that I should post here, rather than create a new one. There's a minor bug in the current (trunk) implementation of the bzrlib-based changelog prepare on my system, which can be fixed with a patch that I am attaching.
