Ticket #402 (new defect)

Opened 17 months ago

Last modified 13 months ago

moap cl ci commits extra files to svn

Reported by: anonymous Owned by: thomas
Priority: critical Milestone: 0.2.7
Component: moap Version: TRUNK
Keywords: Cc:

Description

E.g. below "src/ui/edit/main-page-patterns.c" was *not* menat to be committed.

> more ChangeLog
2009-04-05  Stefan Kost  <ensonic@users.sf.net>

	* src/lib/core/machine.c:
	* src/lib/core/wave.c:
	* src/lib/core/wire-pattern.c:
	* src/lib/core/wire.c:
	* src/ui/edit/gtkvumeter.c:
	* src/ui/edit/machine-canvas-item.c:
	* src/ui/edit/pattern-editor.c:
	* src/ui/edit/wave-viewer.c:
	* src/ui/edit/wire-canvas-item.c:
	  More clang checker fixes: remove dead code, fix some logic bugs. Also chain
	  up in out custom widgets.

2009-04-05  Stefan Kost  <ensonic@users.sf.net>

> moap cl ci
/usr/lib/python2.6/site-packages/moap/util/mail.py:8: DeprecationWarning: the MimeWriter module is deprecated; use the email package instead
  import MimeWriter
Sende          ChangeLog
Sende          src/lib/core/machine.c
Sende          src/lib/core/wave.c
Sende          src/lib/core/wire-pattern.c
Sende          src/lib/core/wire.c
Sende          src/ui/edit/gtkvumeter.c
Sende          src/ui/edit/machine-canvas-item.c
Sende          src/ui/edit/main-page-patterns.c
Sende          src/ui/edit/pattern-editor.c
Sende          src/ui/edit/wave-viewer.c
Sende          src/ui/edit/wire-canvas-item.c
Übertrage Daten ...........
Revision 2333 übertragen.

Attachments

Change History

Changed 17 months ago by Stefan Kost <ensonic@…>

(Identify my self)

Changed 17 months ago by thomas

Trying this on your repository dump, I get this:

[moap-trunk] [thomas@ana buzztard]$ MOAP_DEBUG=5 moap cl ci
DEBUG [11400] "moap"                           moap              Apr 14 16:30:27      parse_args called (moap/extern/command/command.py:230)
DEBUG [11400] "changelog"                      changelog         Apr 14 16:30:27      parse_args called (moap/extern/command/command.py:230)
DEBUG [11400] "changelog"                      changelog         Apr 14 16:30:27      changelog: path ChangeLog (moap/command/cl.py:703)
DEBUG [11400] "checkin"                        checkin           Apr 14 16:30:27      parse_args called (moap/extern/command/command.py:230)
DEBUG [11400]                                  vcs               Apr 14 16:30:27      detecting VCS in  (moap/vcs/vcs.py:34)
DEBUG [11400]                                  vcs               Apr 14 16:30:27      trying vcs modules ['bzr', 'cvs', 'git', 'darcs', 'svn', 'git_svn'] (moap/vcs/vcs.py:38)
DEBUG [11400]                                  vcs               Apr 14 16:30:27      did not find bzr (moap/vcs/vcs.py:59)
DEBUG [11400]                                  vcs               Apr 14 16:30:27      did not find cvs (moap/vcs/vcs.py:59)
DEBUG [11400]                                  vcs               Apr 14 16:30:27      did not find git (moap/vcs/vcs.py:59)
DEBUG [11400]                                  darcs             Apr 14 16:30:27      Did not find _darcs directory under /home/thomas/dev/own/moap/trunk/ensonic/b/buzztard (moap/vcs/darcs.py:24)
DEBUG [11400]                                  vcs               Apr 14 16:30:27      did not find darcs (moap/vcs/vcs.py:59)
DEBUG [11400]                                  vcs               Apr 14 16:30:27      detected VCS svn (moap/vcs/vcs.py:56)
DEBUG [11400] "checkin"                        checkin           Apr 14 16:30:27      Commiting files ['src/lib/core/machine.c', 'src/lib/core/wave.c', 'src/lib/core/wire-pattern.c', 'src/lib/core/wire.c', 'src/ui/edit/gtkvumeter.c', 'src/ui/edit/machine-canvas-item.c', 'src/ui/edit/pattern-editor.c', 'src/ui/edit/wave-viewer.c', 'src/ui/edit/wire-canvas-item.c'] (moap/command/cl.py:320)
Sending        ChangeLog
svn: Commit failed (details follow):
svn: Out of date: '/trunk/buzztard/ChangeLog' in transaction '11-1'
[moap-trunk] [thomas@ana buzztard]$ 

so it seems it at least gets the list of files to commit right. (You can try this yourself by doing:

svn up -r 2332
svn diff -c 2333 > patch
patch -p0 < patch
MOAP_DEBUG=5 moap cl ci

you should get the same result as me; please double-check to see if I'm right.)

I'll see if the commit call itself might be wrong.

Changed 17 months ago by thomas

Ok, it seems indeed something is wrong with that command; will investigate further.

Changed 17 months ago by thomas

Looks like this is due to my possible misunderstanding of svn --non-recursive. I thought it would not descend into the given directory. Possibly it descends into that, but not further; in that case, I would have to add only the parents of those directories; but even that would still commit files changed inside those dirs.

Not yet sure what to do here...

Changed 17 months ago by thomas

Seems in 1.5 it is also deprecated:

-N [--non-recursive]     : obsolete; try --depth=files or --depth=immediates

Changed 13 months ago by anonymous

so it seems it at least gets the list of files to commit right. (You can try this yourself by doing:

svn up -r 2332 svn diff -c 2333 > patch patch -p0 < patch MOAP_DEBUG=5 moap cl ci

you should get the same result as me; please double-check to see if I'm right.)

I'll see if the commit call itself might be wrong. Changed 4 months ago by thomas ¶

Ok, it seems indeed something is wrong with that command; will investigate further.

I'm closing it according to the last comment.
----------
 nike air yeezy

Add/Change #402 (moap cl ci commits extra files to svn)

Author


E-mail address and user name can be saved in the Preferences.


Change Properties
<Author field>
Action
as new
as The resolution will be set. Next status will be 'closed'
to The owner will change from thomas. Next status will be 'new'
The owner will change from thomas to anonymous. Next status will be 'assigned'
 
Note: See TracTickets for help on using tickets.