Modify

Ticket #414 (closed enhancement: fixed)

Opened 3 years ago

Last modified 3 years ago

support --no-date --no-reviewer and --no-update flags in moap cl prepare

Reported by: wulczer@… Owned by: thomas
Priority: major Milestone: 0.2.8
Component: moap Version: TRUNK
Keywords: Cc:

Description

This patch adds three new options to the moap cl pr command that:

1) do not put a date tag in the ChangeLog? 2) do not put the reviewed by: and patch by: fields 3) do not update the ChangeLog? from VCS

1) is useful if you are using a different ChangeLog? style, where your commits are already timestamped, so it doesn't make sense to put the date in the ChangeLog? as well

2) is useful if you don't get lots of other people's patches or review and don't want to be annoyed by removing these lines every time

3) is useful if you already know the ChangeLog? is up-to-date and your VCS is slow

Attachments

nodate-noreviewer-noupdate.patch Download (2.6 KB) - added by wulczer@… 3 years ago.

Change History

Changed 3 years ago by wulczer@…

comment:1 Changed 3 years ago by thomas

Can you show me that different ChangeLog? style ? afaik the only properly defined one is the GNU one. I'd like to understand what different styles you want to support.

Do you think it's less work to add those hard-to-remember options than to just delete two lines (4 characters in vim) or wait for vcs to update ?

comment:2 Changed 3 years ago by wulczer@…

I'm using that style for my git commits: the body of the commit message looks like a ChangeLog? entry, so I can generate a ChangeLog? from git log, but I don't need the date, as it's recorded in the commit itself. I use moap to prepare the skeleton for my git commit message.

Adding the (why hard to remember? Anyway, I don't remember them, because I have a wrapper script around moap that adds these options by default) options is not a lot of work, actually, it's no work at all, since it's already implemented. Having to remove these lines *every time* and waiting for the VCS to update *every time* is annoying (annoying enough that I wrote the patches and run moap with them for a couple of months now, for sure).

comment:3 Changed 3 years ago by thomas

  • Status changed from new to closed
  • Resolution set to fixed

(In [460]) patch by: Jan Urbanski

  • moap/command/cl.py: Add options to moap changelog prepare for --no-date, --no-reviewer, --no-update. Revised patch for spelling and removing double negative logic. Fixes #414.
View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.