Changeset 434

Timestamp:

08-04-11 11:04:25 (2 years ago)

Author:

thomas

Message:

• morituri/common/encode.py: wavenc does not have merge_tags, it seems. So don't call an element a tagger, don't merge tags if there is no tagger, and complain if there is no merge_tags when we think there should be.

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• morituri/common/encode.py (modified) (2 diffs)

trunk/ChangeLog

@@ +1 @@
+2011-04-08  Thomas Vander Stichele  <thomas at apestaart dot org>
+
+        * morituri/common/encode.py:
+          wavenc does not have merge_tags, it seems.
+          So don't call an element a tagger, don't merge tags if there is
+          no tagger, and complain if there is no merge_tags when we think
+          there should be.
+
 2011-03-23  Thomas Vander Stichele  <thomas at apestaart dot org>
 

trunk/morituri/common/encode.py

@@ -73 +73 @@
     lossless = True
 
+# FIXME: wavenc does not have merge_tags
 class WavProfile(Profile):
     name = 'wav'
     extension = 'wav'
-    pipeline = 'wavenc name=tagger'
+    pipeline = 'wavenc'
     lossless = True
 
@@ -176 +177 @@
 
         # set tags
-        if self._taglist:
-            tagger.merge_tags(self._taglist, gst.TAG_MERGE_APPEND)
+        if tagger and self._taglist:
+            # FIXME: under which conditions do we not have merge_tags ?
+            # See for example comment saying wavenc did not have it.
+            try:
+                tagger.merge_tags(self._taglist, gst.TAG_MERGE_APPEND)
+            except AttributeError, e:
+                self.warning('Could not merge tags: %r',
+                    log.getExceptionMessage(e))
 
         self.debug('pausing pipeline')