Changeset 441

Timestamp:

21-05-11 13:22:04 (2 years ago)

Author:

thomas

Message:

• morituri/common/checksum.py: Actually raise the exception.
• morituri/common/task.py: Document interface more clearly.
• morituri/test/test_common_checksum.py: Use tcommon for test.common

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• morituri/common/checksum.py (modified) (1 diff)
• morituri/common/task.py (modified) (1 diff)
• morituri/test/test_common_checksum.py (modified) (3 diffs)

trunk/ChangeLog

@@ +1 @@
+2011-05-21  Thomas Vander Stichele  <thomas at apestaart dot org>
+
+        * morituri/common/checksum.py:
+          Actually raise the exception.
+        * morituri/common/task.py:
+          Document interface more clearly.
+        * morituri/test/test_common_checksum.py:
+          Use tcommon for test.common
+
 2011-05-19  Thomas Vander Stichele  <thomas at apestaart dot org>
 

trunk/morituri/common/checksum.py

@@ -75 +75 @@
         if not self.exception:
             self.paused()
+        else:
+            raise self.exception
 
     def getPipelineDesc(self):

trunk/morituri/common/task.py

@@ -74 +74 @@
 
         Subclasses should chain up to me at the beginning.
+
+        Subclass implementations should raise exceptions immediately in
+        case of failure (using set(AndRaise)Exception) first, or do it later
+        using those methods.
+
+        If start doesn't raise an exception, the task should run until
+        complete, or setException and stop().
         """
         self.debug('starting')

trunk/morituri/test/test_common_checksum.py

@@ -12 +12 @@
 from morituri.test import common
 
-from morituri.common import task, checksum, log
+from morituri.common import task, checksum, log, common
+from morituri.image import image
 
-from morituri.test import common
+from morituri.test import common as tcommon
 
 def h(i):
     return "0x%08x" % i
 
-class EmptyTestCase(common.TestCase):
+class EmptyTestCase(tcommon.TestCase):
     def testEmpty(self):
         # this test makes sure that checksumming empty files doesn't hang
@@ -31 +32 @@
         os.unlink(path)
 
-class PathTestCase(common.TestCase):
+class PathTestCase(tcommon.TestCase):
     def _testSuffix(self, suffix):
         self.runner = task.SyncRunner(verbose=False)
@@ -41 +42 @@
         os.unlink(path)
 
-class UnicodePathTestCase(PathTestCase, common.UnicodeTestMixin):
+class UnicodePathTestCase(PathTestCase, tcommon.UnicodeTestMixin):
     def testUnicodePath(self):
         # this test makes sure we can checksum a unicode path