Ticket #45 (new defect)

Opened 3 years ago

Last modified 2 years ago

lame element is deprecated, should use 'lamemp3enc' instead

Reported by: http://openid-provider.appspot.com/nyall@… Owned by: https://thomasvs.myopenid.com/
Priority: major Milestone: future
Component: morituri Version: master
Keywords: Cc:

Description

The 'lame' encoder element has been deprecated from gstreamer (see  http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gst-plugins-ugly-plugins/html/gst-plugins-ugly-plugins-lame.html ). This should be replaced by the 'lamemp3enc' element, which has a simpler interface:

 http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gst-plugins-ugly-plugins/html/gst-plugins-ugly-plugins-lamemp3enc.html

I'd suggest changing:
class MP3VBRProfile(Profile):

name = 'mp3vbr'
extension = 'mp3'
pipeline = 'lame name=tagger quality=0 vbr=new vbr-mean-bitrate=192 ! id3v2mux'
lossless = False

to something like

class MP3VBRProfile(Profile):

name = 'mp3vbr'
extension = 'mp3'
pipeline = 'lamemp3enc name=tagger quality=0 ! id3v2mux'
lossless = False

and
class MP3Profile(Profile):

name = 'mp3'
extension = 'mp3'
pipeline = 'lame name=tagger quality=0 ! id3v2mux'
lossless = False

to
class MP3Profile(Profile):

name = 'mp3'
extension = 'mp3'
pipeline = 'lamemp3enc name=tagger target=bitrate cbr=true bitrate=320 ! id3v2mux'
lossless = False

Change History

comment:1 Changed 2 years ago by https://www.google.com/accounts/o8/id?id=aitoawlw7vrimfrdvxg14x_fdyasjdl5lxrcanw

Related, it should use xingmux as well as id3v2mux, at least for the VBR profile — “allow correct duration reporting and seeking for VBR files.”[1]

 http://mail.gnome.org/archives/commits-list/2010-May/msg09214.html

comment:2 Changed 2 years ago by http://thomasvs.myopenid.com/

  • Milestone changed from 0.1.2 to future
Note: See TracTickets for help on using tickets.