Crash on 'rip image retag'

[https://www.google.com/accounts/o8/id?id=aitoawlw7vrimfrdvxg14x_fdyasjdl5lxrcanw]

After ripping, I tried the 'rip image retag' command just to see what would happen.

It crashed, after running through all 5 steps:

$ rip image retag Sanctuary\ -\ Refuge\ Denied/*.cue
Retagging image 'Sanctuary - Refuge Denied/Sanctuary? - Refuge Denied.cue'
Message: pygobject_register_sinkfunc is deprecated (GstObject?)
Matching releases:
Artist : Sanctuary
Title : Refuge Denied

Traceback (most recent call last):

File "/usr/bin/rip", line 35, in <module>

sys.exit(main.main(sys.argv[1:]))

File "/usr/lib/python2.6/dist-packages/morituri/rip/main.py", line 12, in main

ret = c.parse(argv)

File "/usr/lib/python2.6/dist-packages/morituri/extern/command/command.py", line 329, in parse

return self.subCommands[command].parse(args[1:])

File "/usr/lib/python2.6/dist-packages/morituri/extern/command/command.py", line 329, in parse

return self.subCommands[command].parse(args[1:])

File "/usr/lib/python2.6/dist-packages/morituri/extern/command/command.py", line 300, in parse

ret = self.do(args)

File "/usr/lib/python2.6/dist-packages/morituri/rip/image.py", line 129, in do

runner.run(t)

File "/usr/lib/python2.6/dist-packages/morituri/common/task.py", line 390, in run

raise TaskException?(task.exception, message=task.exceptionMessage)

morituri.common.task.TaskException?: (TypeError?('Tags not written',), 'exception TypeError? at /usr/lib/python2.6/dist-packages/morituri/common/encode.py:502: stopped(): Tags not written')

[thomas]

In [429]:

• morituri/common/encode.py: Debug failing to write tags better. See #60.

[http://thomasvs.myopenid.com/]

Have not been able to reproduce this myself yet. Please provide some additional feedback.

[https://www.google.com/accounts/o8/id?id=aitoawn34djhom6djrz2dspjlzw9katbubs72oo]

In current SVN I now get:

$ rip image retag */*.cue
Retagging image 'Fleetwood Mac - Greatest Hits/Fleetwood? Mac - Greatest Hits.cue'
Traceback (most recent call last):

File "/usr/local/bin/rip", line 35, in <module>

sys.exit(main.main(sys.argv[1:]))

File "/usr/local/lib/python2.7/site-packages/morituri/rip/main.py", line 16, in main

ret = c.parse(argv)

File "/usr/local/lib/python2.7/site-packages/morituri/rip/main.py", line 89, in parse

logcommand.LogCommand?.parse(self, argv)

File "/usr/local/lib/python2.7/site-packages/morituri/extern/command/command.py", line 343, in parse

return self.subCommands[command].parse(args[1:])

File "/usr/local/lib/python2.7/site-packages/morituri/extern/command/command.py", line 343, in parse

return self.subCommands[command].parse(args[1:])

File "/usr/local/lib/python2.7/site-packages/morituri/extern/command/command.py", line 312, in parse

ret = self.do(args)

File "/usr/local/lib/python2.7/site-packages/morituri/rip/image.py", line 112, in do

cueImage.setup(runner)

File "/usr/local/lib/python2.7/site-packages/morituri/image/image.py", line 74, in setup

runner.run(verify)

File "/usr/local/lib/python2.7/site-packages/morituri/extern/task/task.py", line 500, in run

raise TaskException?(task.exception, message=msg)

morituri.extern.task.task.TaskException?: (QueryError?('query failed',), 'exception QueryError? at /usr/local/lib/python2.7/site-packages/morituri/image/image.py:173: paused(): query failed\nTraceback (most recent call last):\n File "/usr/local/lib/python2.7/site-packages/morituri/extern/task/task.py", line 340, in next\n task.start(self.runner)\n File "/usr/local/lib/python2.7/site-packages/morituri/extern/task/gstreamer.py", line 102, in start\n done = self.paused()\n File "/usr/local/lib/python2.7/site-packages/morituri/image/image.py", line 173, in paused\n length, qformat = sink.query_duration(self.gst.FORMAT_DEFAULT)\nQueryError: query failed\n')

Hope this helps.

[https://www.google.com/accounts/o8/id?id=aitoawl7nkd5qf_52ofoqc5dwqfblmfrub2kof0]

I have excactly the same error. I have used morituri since the first version (0.1.0 I guess), and should retag some albums that was ripped before you supported ALBUMARTIST-tag.

I'm on Ubuntu 11.10 if that helps...

[https://www.google.com/accounts/o8/id?id=aitoawl7nkd5qf_52ofoqc5dwqfblmfrub2kof0]

Ok, my last comment wasn't very helpful, I guess.

I can't get it to work on Ubuntu 11.10. I tried Fedora 16, with same result (different error though), while Fedora 14 works fine. I didn't test 15.

Anyway, attached is DEBUG 5 output, in case it helps.

[https://thomasvs.myopenid.com/]

I updated the retag code. Could you please verify if it works now?

[https://www.google.com/accounts/o8/id?id=aitoawl7nkd5qf_52ofoqc5dwqfblmfrub2kof0]

No crashes anymore :) Have still problems with some cd's, but that's in ticket #87 :)

I'm not the reporter, but I think this bug can be closed.

[https://www.google.com/accounts/o8/id?id=aitoawk5srcm6yjgqjx9oa1ruownfuzsldd8l5w]

I am seeing this for quite a few albums as well. I will attach a full RIP_DEBUG=5 log. I am getting the impression that the problem comes up when the album artist is changed. I will have to verify this though. I am using a current git checkout.

[https://www.google.com/accounts/o8/id?id=aitoawk5srcm6yjgqjx9oa1ruownfuzsldd8l5w]

I think I can explain the problem. I am not sure however what the correct solution is.

The album the above log refers to is a compilation / dj-mix. The album artist used to be "Various Artists". This was changed to be the person who picked the tracks. As far as I can tell lines 443f in common/program.py

if self.metadata and self.metadata.various:                                                                                  
    ret["album-artist"] = albumArtist.encode('utf-8')                                                                         

only set the album-artist field if the album artist is VA. Now, during retag the artist neither gets cleared nor does it get set to the new value "DJ Maestro". Hence it mismatches from what is expected (no value set).

If I remove the condition this particular retag works. Probably always setting the album-artist is the correct solution since there are Various Artist cases where the album artist is known.