Ticket #66 (assigned defect)

Opened 2 years ago

Last modified 4 months ago

morituri does not put .log and .m3u in correct folders

Reported by: https://profiles.google.com/104370926969533441147 Owned by: https://profiles.google.com/104370926969533441147
Priority: major Milestone: future
Component: morituri Version: master
Keywords: Cc:

Description

when defining DISC and TRACK profiles, morituri fails to put the m3u and log files in the appropriate folder. Apart from this being annoying it also breaks accuraterip feature, as morituri simply fails to see the files for checking.

crash:

AccurateRip? URL  http://www.accuraterip.com/accuraterip/a/a/5/dBAR-007-001155aa-0066a7b8-6d0ea907.bin
4 AccurateRip? reponses found
Traceback (most recent call last):

File "/usr/bin/rip", line 35, in <module>

sys.exit(main.main(sys.argv[1:]))

File "/usr/lib/python2.7/site-packages/morituri/rip/main.py", line 12, in main

ret = c.parse(argv)

File "/usr/lib/python2.7/site-packages/morituri/rip/main.py", line 77, in parse

logcommand.LogCommand?.parse(self, argv)

File "/usr/lib/python2.7/site-packages/morituri/extern/command/command.py", line 335, in parse

return self.subCommands[command].parse(args[1:])

File "/usr/lib/python2.7/site-packages/morituri/extern/command/command.py", line 335, in parse

return self.subCommands[command].parse(args[1:])

File "/usr/lib/python2.7/site-packages/morituri/extern/command/command.py", line 304, in parse

ret = self.do(args)

File "/usr/lib/python2.7/site-packages/morituri/rip/cd.py", line 318, in do

prog.verifyImage(runner, responses)

File "/usr/lib/python2.7/site-packages/morituri/common/program.py", line 517, in verifyImage

verifytask = image.ImageVerifyTask?(cueImage)

File "/usr/lib/python2.7/site-packages/morituri/image/image.py", line 210, in init

path = image.getRealPath(index.path)

File "/usr/lib/python2.7/site-packages/morituri/image/image.py", line 62, in getRealPath

return self.cue.getRealPath(path)

File "/usr/lib/python2.7/site-packages/morituri/image/cue.py", line 214, in getRealPath

raise KeyError?, "Cannot find file for %r" % path

KeyError?: "Cannot find file for u'01-The Moor.flac'"
zsh: exit 1 rip cd rip --offset 6 --disc-template="%A/%d" --track-template="%A/%d/%t-%n"

Change History

comment:1 Changed 2 years ago by http://thomasvs.myopenid.com/

  • Milestone changed from 0.1.2 to future

[495] adds guarding against using incompatible templates. Your disc template is such that it would store .cue and similar files one level up from your tracks.

I don't know if that's intentional on your part, or if you meant to use something like %A/%d/%d in your disc template ?

For now, since there is no code yet to handle the disc files being in a different directory than the tracks, I'm disallowing it in the code.

Let me know how to further handle this.

comment:2 Changed 4 months ago by http://thomasvs.myopenid.com/

  • Owner changed from https://thomasvs.myopenid.com/ to https://profiles.google.com/104370926969533441147
  • Status changed from new to assigned
Note: See TracTickets for help on using tickets.