Ticket #71 (new defect)

Opened 2 years ago

Last modified 6 months ago

Ripping Glasvegas - EUPHORIC /// HEARTBREAK \\\ failed

Reported by: http://petercarlsson.myopenid.com/ Owned by: https://thomasvs.myopenid.com/
Priority: major Milestone: future
Component: morituri Version: master
Keywords: characters Cc:

Description

The filename for this CD caused morituri to fail.

This patch solves the problem:

diff morituri/common/program.py ./program_patched.py
63c63,65
<     return "-".join(text.split("/"))
---
>     tmpText = "-".join(text.split("/"))
>     tmpText = "-".join(tmpText.split("\\"))
>     return tmpText
Name before: Glasvegas - EUPHORIC /// HEARTBREAK \\\
Name after:  Glasvegas - EUPHORIC --- HEARTBREAK ---

Change History

comment:1 Changed 9 months ago by http://thomasvs.myopenid.com/

Backslashes are fixed by escaping them as per #89.

Forward slashes are not allowed in Unix filenames. Not sure yet what to do - it makes sense to convert them to e.g. - but then both should be done, no ?

Suggestions as to what to name the files in this ticket and in #89 are welcome.

comment:2 Changed 9 months ago by http://petercarlsson.myopenid.com/

Personally I would prefer both backslashes and forwardslashes to be converted to - as suggested in my original comment. Both would otherwise became a trouble, forwardslash in Unix/Linux? and backslash in Windows if one choose to copy to a media player which often uses FAT32/NTFS.

comment:3 Changed 6 months ago by https://thomasvs.myopenid.com/

  • Keywords characters added
  • Milestone changed from 0.1.3 to future
Note: See TracTickets for help on using tickets.