Ticket #92 (new defect)

Opened 14 months ago

Last modified 6 months ago

Crash when trackResult does not contain a peak level.

Reported by: https://www.google.com/accounts/o8/id?id=aitoawk5srcm6yjgqjx9oa1ruownfuzsldd8l5w Owned by: https://thomasvs.myopenid.com/
Priority: major Milestone: future
Component: morituri Version: master
Keywords: Cc:

Description

For at least one hidden track 0 I have observed a problem with the peak in trackResult being None. The attached patch fixes the resulting crashes. However, what is strange that sometimes the troublesome track resulted in a peak of 0.

Attachments

0001-Do-not-fail-if-trackResult.peak-is-None.patch Download (1.7 KB) - added by https://www.google.com/accounts/o8/id?id=aitoawk5srcm6yjgqjx9oa1ruownfuzsldd8l5w 14 months ago.
Patch to deal with 'None' peak level.

Change History

Changed 14 months ago by https://www.google.com/accounts/o8/id?id=aitoawk5srcm6yjgqjx9oa1ruownfuzsldd8l5w

Patch to deal with 'None' peak level.

comment:1 Changed 14 months ago by http://thomasvs.myopenid.com/

I specifically leave the crashing behaviour there because it should never be None. If it is, then it means that no samples were actually decoded.

What file causes the behaviour ?

comment:2 Changed 14 months ago by http://thomasvs.myopenid.com/

Is it a .flac file? I recently did a patch for flacdec related to this.

comment:3 Changed 14 months ago by https://www.google.com/accounts/o8/id?id=aitoawk5srcm6yjgqjx9oa1ruownfuzsldd8l5w

Yes, it is a flac file. I don't quite remember which one it was. I will try to find out.

comment:4 Changed 6 months ago by https://thomasvs.myopenid.com/

  • Milestone changed from 0.1.3 to future

Let me know please.

Note: See TracTickets for help on using tickets.