Ticket #96 (closed enhancement: fixed)

Opened 13 months ago

Last modified 5 months ago

rip image retag: allow specification of release ID

Reported by: http://fias.co.nz/ Owned by: https://thomasvs.myopenid.com/
Priority: minor Milestone: 0.2.0
Component: morituri Version: master
Keywords: Cc: don@…

Description

It seems that an obvious use-case of retag is not supported: switching release IDs after a rip.

Could a --release-id parameter be added to the "image retag" command? Or an interactive mode added that shows the matching releases, then allows selection of one of them? Or both?

Change History

comment:1 Changed 13 months ago by http://fias.co.nz/

  • Cc don@… added

comment:2 Changed 11 months ago by https://www.google.com/accounts/o8/id?id=aitoawker5jexvatmzeevyhdfselupnsulk74bg

I have one album (Nirvana - In Utero) where a wrong release ID is assumed as well. Being able to change this before or even after rip would be great

comment:3 follow-up: ↓ 4 Changed 11 months ago by http://thomasvs.myopenid.com/

Try -R/--release-id to rip cd rip on trunk and see if that works for you.

comment:4 in reply to: ↑ 3 Changed 11 months ago by https://www.google.com/accounts/o8/id?id=aitoawker5jexvatmzeevyhdfselupnsulk74bg

Replying to http://thomasvs.myopenid.com/:

Try -R/--release-id to rip cd rip on trunk and see if that works for you.

Looks good... but I didn't mean to hijack the bug, the requested functionality (chosing ID when re-tagging) would be even greater.

comment:5 Changed 6 months ago by https://thomasvs.myopenid.com/

  • Milestone changed from 0.1.3 to future

I'll keep this bug open to add that, I agree the use case makes a lot of sense.

comment:6 Changed 6 months ago by https://thomasvs.myopenid.com/

  • Milestone changed from future to 0.2.0

comment:7 Changed 6 months ago by thomas

  • Status changed from new to closed
  • Resolution set to fixed

In [708]:

  • morituri/common/program.py: add release id to output.
  • morituri/rip/image.py: add --release-id to rip image retag. Fixes #96.

comment:8 Changed 5 months ago by https://www.google.com/accounts/o8/id?id=aitoawker5jexvatmzeevyhdfselupnsulk74bg

Great news, however I have a problem with the implementation in trunk. I have one album (British Steel by Judas Priest) which was tagged in a different track order. The EU and US releases differ, and I guess someone linked my disk ID to the wrong release? Anyway I found the disk ID I need, but I am unable to use it:

[mimox Judas Priest - British Steel]$ rip image retag --release-id b82929da-fb3a-3c4b-94c9-49d182717593 Judas\ Priest\ -\ British\ Steel.cue 
Retagging image 'Judas Priest - British Steel.cue'
** Message: pygobject_register_sinkfunc is deprecated (GstObject)
MusicBrainz disc id is YZIqG3PVoA8WkCOIVjZct5TI5mU-
Disc duration: 00:36:07.693

Matching releases:
Artist  : Judas Priest
Title   : British Steel
Duration: 00:35:58.932
URL     : http://musicbrainz.org/release/129ae5ec-5211-31d9-9172-3c1538a99d43
Release : 129ae5ec-5211-31d9-9172-3c1538a99d43
Artist  : Judas Priest
Title   : British Steel
Duration: 00:35:58.932
URL     : http://musicbrainz.org/release/369e897a-a514-3f31-8e35-cd237293b2d1
Release : 369e897a-a514-3f31-8e35-cd237293b2d1
Artist  : Judas Priest
Title   : British Steel
Duration: 00:35:58.932
URL     : http://musicbrainz.org/release/439cb36a-68be-34de-be53-f372a3f79f66
Release : 439cb36a-68be-34de-be53-f372a3f79f66
Requested release id b82929da-fb3a-3c4b-94c9-49d182717593 but none matchNot in MusicBrainz database, skipping

Also note the missing newline in the last line of the output.

Note: See TracTickets for help on using tickets.